Export multi methods#579
Merged
Merged
Conversation
This reverts commit 9443e1c.
Collaborator
Author
|
@SteveL-MSFT Hi Steve, I was actually a bit suprised my change broke the build. The reason is, after debugging and checking out the history on #556, I'm doubting if the change there was fully tested. If I add the following line in the if ($DesiredState.properties)
{
# set each property of $dscResourceInstance to the value of the property in the $desiredState INPUT object
$DesiredState.properties.psobject.properties | ForEach-Object -Process {
$dscResourceInstance.$($_.Name) = $_.Value
}
}
($dscResourceInstance | ConvertTo-Json -Depth 10 -Compress) | Write-DscTrace -Operation TraceI could see this: Clearly the properties are added to the output result set. That's why the tests are failing. Shouldn't these be filtered out? |
|
The diagnostic code is checking the wrong thing; 'filtering out' is done by constructing a new hashtable result object. Similarly for 'Export' operation - |
anmenaga
suggested changes
Oct 25, 2024
anmenaga
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
Address issue #578. Additional class can be added if needed to have only one export method.
PR Context