ConvertTo-MOFInstance: Include resource properties with empty array value #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where resource properties with empty array values were being excluded from MOF file compilation in PowerShell 7, creating inconsistency with Windows PowerShell 5.1 behavior.
- Removes conditional logic that excluded empty array properties from MOF generation
- Ensures consistent MOF compilation behavior across PowerShell versions
SteveL-MSFT
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
This looks fine to me, although I don't have the history of why the original code excluded empty arrays. @TravisEz13 do you have any recollection of this behavior since the conditional check is very explicit (although it could simply be wrong).
SteveL-MSFT
requested changes
Aug 11, 2025
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #126
PR Context
When switching from Windows PowerShell 5.1 to PowerShell 7 for DSC MOF compilation people are expecting no changes to the resulting MOF files. This is currently not the case for resource properties with an empty array value.