Skip to content

Conversation

tgauth
Copy link
Collaborator

@tgauth tgauth commented Oct 16, 2025

PR Summary

  • bump libressl to latest version

@tgauth
Copy link
Collaborator Author

tgauth commented Oct 16, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tgauth
Copy link
Collaborator Author

tgauth commented Oct 16, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tgauth tgauth requested a review from TravisEz13 October 16, 2025 15:46
@TravisEz13 TravisEz13 requested a review from Copilot October 16, 2025 18:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Bumps LibreSSL dependency to 4.2.0 and updates associated build patches/resources for Windows (including ARM64 support).

  • Updates version fields and resource file (version.rc) to 4.2.0.
  • Adds ARM64 (aarch64) Windows CPU capability initialization and adjusts CMake logic for ARM/ARM64.
  • Refreshes source archive checksum and applies new patch set.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
contrib/win32/openssh/vcpkg_overlay_ports/libressl/vcpkg.json Bumps LibreSSL version; retains existing port-version.
contrib/win32/openssh/vcpkg_overlay_ports/libressl/portfile.cmake Updates source SHA512 and adds new aarch64 patch to extraction list.
contrib/win32/openssh/vcpkg_overlay_ports/libressl/modify-crypto-cmakelists.patch Adds version.rc to COMPAT_SRC for Windows resource embedding.
contrib/win32/openssh/vcpkg_overlay_ports/libressl/modify-cmakelists.patch Alters processor detection; injects system libs for ARM/ARM64 via CMAKE_C_STANDARD_LIBRARIES.
contrib/win32/openssh/vcpkg_overlay_ports/libressl/add-version-file.patch Updates version numbers in resource file to 4.2.0.
contrib/win32/openssh/vcpkg_overlay_ports/libressl/aarch64-windows.diff Introduces Windows-specific ARM64 CPU capabilities initialization source file.
contrib/win32/openssh/vcpkg.json Updates referenced LibreSSL dependency version.
Comments suppressed due to low confidence (1)

contrib/win32/openssh/vcpkg_overlay_ports/libressl/modify-cmakelists.patch:1

  • Modifying CMAKE_C_STANDARD_LIBRARIES directly in architecture condition blocks globally affects all targets and can lead to duplicated or unintended linkage; prefer appending these system libraries to an existing PLATFORM_LIBS variable or using target_link_libraries() on the specific LibreSSL targets for clearer scoping.
diff --git a/CMakeLists.txt b/CMakeLists.txt

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tgauth
Copy link
Collaborator Author

tgauth commented Oct 16, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant