Fix SAM3 loading in desktop ComfyUI installs#113
Open
artokun wants to merge 1 commit into
Open
Conversation
|
Hopefully this gets merged soon, is there any temporary workaround? |
|
this comfy-env package seems very problematic rebuilding a unique enviroment again from what it looks like when quickly scaning the code is also loading custom wheels the author made |
Author
|
@colorrin you can use my fork from this PR in the meantime until it gets patched, that's what I am using |
|
Thanks a lot @artokun, it worked perfectly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
egister_nodes() runs
odes package so older_paths, comfy_api, and other ComfyUI modules resolve under desktop installs
Problem
On desktop ComfyUI installs, comfy-env isolation can scan comfyui-sam3 before the ComfyUI core path is available on sys.path. That causes imports like older_paths to fail during metadata scan, so the node registers 0 nodes even though dependencies are installed.
Validation
egister_nodes()