fix: stop right-click bubbling to node context menu in Nodes 2.0#137
Open
jtydhr88 wants to merge 1 commit into
Open
fix: stop right-click bubbling to node context menu in Nodes 2.0#137jtydhr88 wants to merge 1 commit into
jtydhr88 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canvas contextmenu listeners in the Point/BBox/MultiRegion/ Interactive collectors called e.preventDefault() but not e.stopPropagation(). Under LiteGraph this was sufficient because the DOM widget canvas absorbed the event. Under Nodes 2.0 (vueNodes) the event bubbles to NodeWidgets.vue's @contextmenu handler, which opens the node's context menu and blocks negative-point/bbox interaction.
Adding stopPropagation keeps the right-click confined to the canvas.