Skip to content

desktop: fix .rstrip(".git") mangling node names ending in g/i/t/. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PozzettiAndrea wants to merge 1 commit into
base: main
Choose a base branch
from
Open

desktop: fix .rstrip(".git") mangling node names ending in g/i/t/. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/comfy_test/cli/_desktop_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,11 @@ def _sig_cleanup(signum, _frame):
# rate-limit). cdp_driver picks up the list via COMFY_TEST_WORKFLOWS env.
from comfy_test.cli._nodelink import clone_node, expand_nodelink

url = expand_nodelink(args.nodelink).rstrip(".git")
# NOT .rstrip(".git") -- that strips ANY trailing chars in {'.','g','i','t'},
# so "ComfyUI-UniRig.git" becomes "ComfyUI-UniR" and every downstream fetch
# (pyproject.toml, comfy-test.toml, workflows/) 404s, leaving the run with
# "no workflows ran" but rc=0.
url = expand_nodelink(args.nodelink).removesuffix(".git")
node_name = url.rsplit("/", 1)[-1]

clone_root = Path(tempfile.mkdtemp(prefix="comfy-test-desktop-clone-"))
Expand Down
Loading