Migrate react#188
Conversation
…lore into responsiveness
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9250661 | Triggered | Generic High Entropy Secret | d4b778e | src/components/DisplayDetails.jsx | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | d4b778e | old-assets/app.js | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | bba36c4 | app.js | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | 556f1b9 | old-assets/app.js | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | d4b778e | src/components/index.js | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | bba36c4 | app.js | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | d4b778e | src/components/index.js | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | 58077a5 | src/components/DefaultDisplay.jsx | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | 58077a5 | src/components/DisplayDetails.jsx | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | bba36c4 | app.js | View secret |
| 9250661 | Triggered | Generic High Entropy Secret | bba36c4 | app.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
@PranavBarthwal my last pull request need to be approved for this code to work |
|
pull request #77 |
|
@PranavBarthwal also added the documentation on how to start this project in this branch readme.md |
Okay. Fix conflicts in that PR then I'll merge that after that I'll merge this. |
|
Hey @shaurya35, Get it done by the end of the day, or we will need to close it and assign it to someone else. |
|
hi @surajvast1 I wanted to clarify some things. If I make all the changes in this repo that do not conflict with the main files, will you merge my last pull request #77 and then this one? So that I do not have to make the changes twice. It will result in successful migration without any problems, but you'll have to verify whether everything from your current website is working the same or not. I may need 1.5 to 2 days for this. |
|
Yeah sure . |
|
Hi @surajvast1 An overview of what I did: Problem: Solution: It will help people solve the remaining problems in the future (if they can do so). If you wish to you can merge the code, you wont be having any problems in assigning people future tasks related the same. Thank you |
|
you can refer my code for the same |
|
Also, a suggestion: make sure not to wait for any merge requests because they have piled up so much that it was very hard for me to figure it out. |
|
There are conflicting files here the problem is you are directly pushing your changes to the main branch where changes are happening frequently. Create a fork of the repo and change your remote locally and push your changes to the forked repo and create a new pull request from that . |
|
@surajvast1 okay let me try |
|
@surajvast1 Discord Username: |
|
Hey @shaurya35 sent you a message, check || |
|
@surajvast1 how are we going forward with this merge and my last merge? |
|
Hi @shaurya35, Your files contained many bugs and errors, and the APIs were not connected. Thanks to the community, we were able to resolve these issues and create a functional solution. We would like to close this matter for now. Please feel free to start by creating new issues |
|
Hi @surajvast1 Also, could you address my last merge request, because it was approved |
|
@shaurya35 No stress .The files you share were raw and were on the initial stage . We couldnt merge the files since it required complete change in the codebase .You can start working on some better issues. |
|
@surajvast1 |
|
Yeah Sureeee |
Issue number: #159
Migrated all the assets and functions as components.
Checklist:
contributing.mdfile before contributing