Skip to content

Migrate react#188

Open
shaurya35 wants to merge 31 commits intoPranavBarthwal:mainfrom
shaurya35:migrate-react
Open

Migrate react#188
shaurya35 wants to merge 31 commits intoPranavBarthwal:mainfrom
shaurya35:migrate-react

Conversation

@shaurya35
Copy link
Copy Markdown
Contributor

@shaurya35 shaurya35 commented May 16, 2024

Issue number: #159

Migrated all the assets and functions as components.

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 16, 2024

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9250661 Triggered Generic High Entropy Secret d4b778e src/components/DisplayDetails.jsx View secret
9250661 Triggered Generic High Entropy Secret d4b778e old-assets/app.js View secret
9250661 Triggered Generic High Entropy Secret bba36c4 app.js View secret
9250661 Triggered Generic High Entropy Secret 556f1b9 old-assets/app.js View secret
9250661 Triggered Generic High Entropy Secret d4b778e src/components/index.js View secret
9250661 Triggered Generic High Entropy Secret bba36c4 app.js View secret
9250661 Triggered Generic High Entropy Secret d4b778e src/components/index.js View secret
9250661 Triggered Generic High Entropy Secret 58077a5 src/components/DefaultDisplay.jsx View secret
9250661 Triggered Generic High Entropy Secret 58077a5 src/components/DisplayDetails.jsx View secret
9250661 Triggered Generic High Entropy Secret bba36c4 app.js View secret
9250661 Triggered Generic High Entropy Secret bba36c4 app.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@shaurya35
Copy link
Copy Markdown
Contributor Author

@PranavBarthwal my last pull request need to be approved for this code to work
I think it can conflict with main branch
you can check and let me know

@shaurya35
Copy link
Copy Markdown
Contributor Author

pull request #77

@shaurya35
Copy link
Copy Markdown
Contributor Author

@PranavBarthwal also added the documentation on how to start this project in this branch readme.md

@PranavBarthwal
Copy link
Copy Markdown
Owner

@PranavBarthwal my last pull request need to be approved for this code to work
I think it can conflict with main branch
you can check and let me know

Okay. Fix conflicts in that PR then I'll merge that after that I'll merge this.

@surajvast1
Copy link
Copy Markdown
Collaborator

Hey @shaurya35,
You need to resolve the conflicts and push your code as soon as possible. If you need help, please ask. This is a significant issue, and we cannot merge other changes until we have a stable repository.

Get it done by the end of the day, or we will need to close it and assign it to someone else.

@shaurya35
Copy link
Copy Markdown
Contributor Author

hi @surajvast1
I could not make the changes, as I was working on some very important tasks which I got.

I wanted to clarify some things.

If I make all the changes in this repo that do not conflict with the main files, will you merge my last pull request #77 and then this one? So that I do not have to make the changes twice.

It will result in successful migration without any problems, but you'll have to verify whether everything from your current website is working the same or not.

I may need 1.5 to 2 days for this.
Would that be okay with you?

@surajvast1
Copy link
Copy Markdown
Collaborator

Yeah sure .

@shaurya35
Copy link
Copy Markdown
Contributor Author

Hi @surajvast1

An overview of what I did:

Problem:
I was not able to sync the features with the current React environment since I didn't implement those features, its getting too hard for me to implement it in React. I spent like 4 hours figuring out the features that others implemented.

Solution:
I wasn't able to add all the new features that were conflicting with the main branch, but what I did implement is add a new folder that contains all the old assets that are on the latest branch of cosmoexplore. So that there is no particular conflict, you can access both the new react app and the old HTML app at the same time.

It will help people solve the remaining problems in the future (if they can do so).

If you wish to you can merge the code, you wont be having any problems in assigning people future tasks related the same.

Thank you

@shaurya35
Copy link
Copy Markdown
Contributor Author

you can refer my code for the same

@shaurya35
Copy link
Copy Markdown
Contributor Author

Also, a suggestion: make sure not to wait for any merge requests because they have piled up so much that it was very hard for me to figure it out.

@surajvast1
Copy link
Copy Markdown
Collaborator

surajvast1 commented May 20, 2024

There are conflicting files here the problem is you are directly pushing your changes to the main branch where changes are happening frequently. Create a fork of the repo and change your remote locally and push your changes to the forked repo and create a new pull request from that .

@surajvast1 surajvast1 added the help wanted Extra attention is needed label May 20, 2024
@shaurya35
Copy link
Copy Markdown
Contributor Author

@surajvast1 okay let me try

@surajvast1 surajvast1 removed their request for review May 20, 2024 08:17
@shaurya35
Copy link
Copy Markdown
Contributor Author

@surajvast1
Hi, can you come to Discord to chat about how to fix this issue?
Today evening?

Discord Username:
_shaurya35

@surajvast1
Copy link
Copy Markdown
Collaborator

surajvast1 commented May 20, 2024

Hey @shaurya35 sent you a message, check ||

@shaurya35
Copy link
Copy Markdown
Contributor Author

@surajvast1 how are we going forward with this merge and my last merge?

@surajvast1
Copy link
Copy Markdown
Collaborator

Hi @shaurya35,

Your files contained many bugs and errors, and the APIs were not connected. Thanks to the community, we were able to resolve these issues and create a functional solution. We would like to close this matter for now.

Please feel free to start by creating new issues

@shaurya35
Copy link
Copy Markdown
Contributor Author

Hi @surajvast1
I think I spent an ample amount of time migrating to react but it is okay
can you point me out the bugs and errors I did not mention?

Also, could you address my last merge request, because it was approved
Then you can go ahead and close this request.

@surajvast1
Copy link
Copy Markdown
Collaborator

@shaurya35 No stress .The files you share were raw and were on the initial stage . We couldnt merge the files since it required complete change in the codebase .You can start working on some better issues.
I think we are clear here.

@shaurya35
Copy link
Copy Markdown
Contributor Author

@surajvast1
yeah sure no problem
I hope I will be provided with some bonus for future pull requests.
I will get back on this repo after my exams if that's okay with you.
Have a great day
You may close this thread

@surajvast1
Copy link
Copy Markdown
Collaborator

Yeah Sureeee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants