Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

feat: vscode extension #87

Merged
merged 27 commits into from
Feb 25, 2023
Merged

feat: vscode extension #87

merged 27 commits into from
Feb 25, 2023

Conversation

Slowlife01
Copy link
Contributor

@Slowlife01 Slowlife01 commented Oct 13, 2022

image

Create Command

image
image

image
image

Note
This is when you exit midway

image

Modify Command

image
image
image
image

See README for additional info

@Slowlife01 Slowlife01 marked this pull request as ready for review October 17, 2022 08:33
@Slowlife01
Copy link
Contributor Author

Might add translate command later

@Slowlife01

This comment was marked as resolved.

@Slowlife01 Slowlife01 marked this pull request as draft October 19, 2022 07:38
@Slowlife01
Copy link
Contributor Author

Slowlife01 commented Oct 19, 2022

Should be fine now, please test it

Note
Run vsce package --no-dependencies to build the Extension
Run code --install-extension {path} to install the Extension

@Slowlife01 Slowlife01 marked this pull request as ready for review October 19, 2022 12:34
@Timeraa Timeraa requested review from Bas950 and Timeraa October 23, 2022 18:23
Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move apps/extensions and apps/cli to the main folder?

Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something to discuss with @Timeraa, should we .gitignore the bin folder or not.

@Timeraa
Copy link
Member

Timeraa commented Nov 11, 2022

Sorry for the delay, why aren't you reusing classes like the ModuleManager from the cli or things like fetchSchema? I noticed that you are reusing other functions from it but not everything.

@Bas950
Copy link
Member

Bas950 commented Dec 6, 2022

image
Its impossible to see what you are inputting after you have touched the input field, a URL for image, thumbnail, website url? what url?

@Bas950
Copy link
Member

Bas950 commented Dec 7, 2022

image
is it me or does enter not do anything now?

@Slowlife01
Copy link
Contributor Author

image
is it me or does enter not do anything now?

I think the validation failed and it doesn't show the error message

@Timeraa
Copy link
Member

Timeraa commented Feb 5, 2023

Hey @Slowlife01,

Sorry this took so long to get reviewed, lot's of things came into my way.

Can you resolve the conflicts on this PR? I also have some improvements you could add to the Extension which you can add now or after the initial release:

  • When modifying a Presence, you could automatically open the Presence's files (presence.ts &/ metadata.json) or show a popup like you already do when you created the Presence
    image
  • When you freshly cloned the repository, you could automatically install the dependencies when you run modify/create a Presence
  • When you are already modifying a Presence and run the command again it should stop the old running compiler as it's no longer needed (imo don't be afraid to give your thoughts on it)
  • Perhaps you can add Open metadata.json to this popup as well
    image

I have also found some errors in the Extension:

  • If you run the compiler (modify) and then kill the terminal of it
    image
    You get this error:
    image

Also once I opened the package.json DeepScan showed me this, maybe take a look at that?
image

@Slowlife01
Copy link
Contributor Author

When you are already modifying a Presence and run the command again it should stop the old running compiler as it's no longer needed (imo don't be afraid to give your thoughts on it)

Bas wanted it to be able to compile multiple Presences at the same time

@Slowlife01 Slowlife01 requested review from Timeraa and Bas950 and removed request for Timeraa and Bas950 February 6, 2023 15:43
@Timeraa Timeraa merged commit 69d6c42 into PreMiD:main Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants