Refactor: Centralized Configuration Management for Predictify Hybrid Contract#132
Merged
Merged
Conversation
…dictify Hybrid contract, including constants, environment support, and validation utilities
…fy Hybrid contract, including ConfigurationNotFound and InvalidFeeConfig
…le in Predictify Hybrid contract
…management in Predictify Hybrid contract
…with new methods for initialization, updating, and resetting configurations
…in Predictify Hybrid contract
…sistency in Predictify Hybrid contract configuration
…tion, updating, validation, and environment detection in Predictify Hybrid contract
Contributor
|
Looks good to me! @1nonlypiece |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a comprehensive configuration management system for the Predictify Hybrid contract, centralizing all constants, configuration structs, and environment-specific settings into a new
config.rsmodule. This improves maintainability, flexibility, and clarity for all contract configuration.Key Changes
New
config.rsmodule:Refactored usage across modules:
fees.rs,voting.rs,extensions.rs, and related modules now referenceconfig.rs.initialize_with_configget_contract_configupdate_contract_configreset_config_to_defaultsget_config_summaryfees_enabledget_environmentvalidate_configurationTest Coverage:
Removed duplication:
Benefits
Closes: #111