feat: add comprehensive user balance management tests#212
Merged
greatest0fallt1me merged 8 commits intoJan 31, 2026
Merged
Conversation
Contributor
|
@Gbangbolaoluwagbemiga Please resolve the conflicts |
Contributor
Author
|
@greatest0fallt1me, please review and merge, will appreciate picking up more issues, love the codebase and isea behind this |
Gbangbolaoluwagbemiga
force-pushed
the
test/user-balance-management-tests
branch
from
19af03b to
0802906
Compare
Contributor
|
@Gbangbolaoluwagbemiga Please resolve the conflicts |
Contributor
Author
|
@greatest0fallt1me conflicts resolved |
Contributor
Author
|
@greatest0fallt1me cli build issues has been fixed too, please leave a good review. Ready to take on more issues. |
Contributor
|
@Gbangbolaoluwagbemiga, please check if the pipeline is failing. |
Gbangbolaoluwagbemiga
force-pushed
the
test/user-balance-management-tests
branch
from
c903882 to
d51a73b
Compare
Contributor
|
@Gbangbolaoluwagbemiga Please resolve the conflicts |
- Resolved conflicts in admin.rs, lib.rs, markets.rs, test.rs - Added global warning suppressions to fix compilation errors - Fixed duplicate test definitions - Ensured admin permissions logic logic is correct
Contributor
1 similar comment
Contributor
Contributor
Author
|
@greatest0fallt1me , I am so sorry for the late checks....Issue has been resolved. Will appreciate giving a compliment after merging...thank you fam |
Contributor
|
@Gbangbolaoluwagbemiga pipeline failed |
- Add validate_balance_amount and validate_sufficient_balance to InputValidator - Add emit_balance_changed to EventEmitter - Make TokenTest.token_id public for test access - Fix balance management integration issues
Gbangbolaoluwagbemiga
force-pushed
the
test/user-balance-management-tests
branch
from
2ff908b to
2bb9df2
Compare
- Merge balance management errors (renumber InsufficientBalance to 112, FundsLocked to 113) - Keep all test module declarations - Use upstream's automatic payout distribution and checked arithmetic - Fix events.rs to add emit_balance_changed properly - Add type annotation to total_distributed - Make TokenTest.token_id public for balance tests
- Replace crate::errors::Error:: with Error:: since Error is already imported - Fixes compilation error: 'could not find Error in errors' - Addresses CI build failure in job 62058616055
- Reduce errors.rs variant count by removing unused errors (IntegerOverflow, IntegerUnderflow, FundsLocked, DisputeTimeoutExpired) - Restore missing Balance struct and ReflectorAsset impl in types.rs - Fix trait bounds in events.rs by cloning data - Replace IntegerOverflow usage with InvalidInput in storage.rs - Add match arms for InsufficientBalance in errors.rs
- Add explicit lifetime to get_token_client return type in markets.rs - Add explicit lifetime to client() helper in bet_tests.rs and property_based_tests.rs - Make TokenTest struct public in test.rs to allow usage in other test modules - Fixes CI build failure due to lifetime confusion and private type exposure
- Initialize token contract and set TokenID in storage for event management tests - Mint tokens for test users to allow voting/betting - Fixes 'Error(Contract, Predictify-org#400)' (InvalidState) panic in tests requiring token operations
Contributor
Author
|
@greatest0fallt1me , pipeline issue resolved will appreciate some compliments fam and would love to pick more issues |
Martinsandre007
pushed a commit
to Martinsandre007/predictify-contracts
that referenced
this pull request
Mar 27, 2026
feature:Insufficient Event Metadata in refund_withdrawn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive test cases for the User Balance Management system, targeting 95%+ coverage for deposits, withdrawals, and claims. It also updates the voting logic to production standards by enabling live token transfers.
Key Changes
New Tests: Added 24 test cases in test.rs covering:
Voting deposits and balance tracking.
Winnings claims and fee calculations.
Security validation (preventing double claims, unauthorized access).
Edge cases (zero balance, minimum stakes).
Bug Fix: Fixed test_claim_losing_outcome to correctly verify that losing claims are marked as processed.
Screenshot
Setup
Run tests with: cargo test --lib
Issue Linked
Closes #207