fix: make unclaimed winnings sweep idempotent - #562
Merged
greatest0fallt1me merged 2 commits intoMay 27, 2026
Merged
Conversation
- Add `winnings_swept: bool` field to Market struct (types.rs); initialized to false in Market::new and all direct struct literals - Add `SweepAlreadyDone = 411` error variant to Error enum (err.rs) - Guard sweep_unclaimed_winnings with early return Err(SweepAlreadyDone) if market.winnings_swept is already true, preventing any repeat treasury credit or state mutation - Set market.winnings_swept = true atomically with the final storage write so the flag is committed in the same operation as the claimed map updates - Already-claimed users continue to be excluded via the existing ClaimInfo::is_claimed() check; the swept flag is an additional layer - Add four tests in unclaimed_winnings_timeout_tests.rs: test_double_sweep_rejected, test_double_sweep_burn_rejected, test_claim_then_sweep_excludes_claimed_user, test_sweep_sets_winnings_swept_flag
|
@michaelvic123 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
The Market struct gained a winnings_swept: bool field in the sweep idempotency fix but the direct struct literal in create_market was missed. This caused a compile error since all struct fields must be initialised. Set it to false (same as Market::new).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
winnings_swept: boolfield to Market struct (types.rs); initialized to false in Market::new and all direct struct literalsSweepAlreadyDone = 411error variant to Error enum (err.rs)Pull Request Description
📋 Basic Information
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
closes #560