Update upgrade_manager.rs#780
Merged
greatest0fallt1me merged 1 commit intoJun 29, 2026
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #703
Dug into this one and wanted to be upfront about what I found.
The WASM hash chain verifier this issue asks for was already built in #619
and shipped in PR #754 —
UpgradeRecordchaining, chain-aware rollback, andan internal
verify_upgrade_chain(env, depth) -> boolinUpgradeManager,with solid test coverage (valid chains, broken chains, empty history).
#619 is closed and that work is real and correct.
What I found missing:
verify_upgrade_chainwas never wired intolib.rsas a public contract entrypoint, unlike every other read-only upgrade query
(
get_contract_version,check_upgrade_available,get_upgrade_history,etc., all of which have a
#[contractimpl]wrapper). That means no externalcaller — auditor, indexer, frontend — could actually invoke it on a deployed
contract. It was only reachable from tests and from the internal call inside
rollback_upgrade.That gap is what this PR closes: a public
verify_upgrade_chainentrypointin
lib.rs, plus tests that call it through the actual contract client(
PredictifyHybridClient) instead of the internal module path, to prove it'sreachable end-to-end.
PR: #619
Flagging the overlap with #619/#754 transparently rather than claiming this
as new work from scratch — the verification logic itself was already done;
this closes the "surfaced public" requirement that was specified but not
fully delivered.