Bug dispute event missing#781
Merged
greatest0fallt1me merged 2 commits intoJun 29, 2026
Merged
Conversation
- Renamed DisputeCreatedEvent to DisputeOpenedEvent - Renamed emit_dispute_created to emit_dispute_opened - Added market_id as topic1 on DisputeOpenedEvent emission - Updated EventSchemaRegistry with 'dispute_opened' and 'dispt_opn' topic - Fixed unclosed impl block in market_id_generator.rs - Added focused test to verify event topics Co-authored-by: gloskull <189399494+gloskull@users.noreply.github.com>
…2815577371611 fix: dispute event missing market_id topic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #750 by renaming the dispute creation event and adding the market_id as a searchable topic.
Changes:
Renamed Event: DisputeCreatedEvent is now DisputeOpenedEvent to match the requested terminology.
Added Topic: In emit_dispute_opened, the market_id is now included as the second element in the topics tuple, which corresponds to topic1 in Soroban event filtering.
Registry Update: Updated EventSchemaRegistry to use the new naming convention and the dispt_opn short symbol.
Compilation Fix: Resolved a syntax error in market_id_generator.rs where an impl block was left open.
New Test: Added a focused unit test in events.rs to verify that DisputeOpenedEvent is emitted with the correct topics in the correct order.
All dispute initiation sites have been updated to use the new emission function.
Closes #750