Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[wip] reduce SQLite locking
not sure about this yet, just looking for now
for example: i saw that worker heartbeats could trigger "database is locked" errors when using SQLite, which seems related to serialization during work pool status transitions.
this pr
worker_heartbeat
by only acquiring lock when neededwith_for_update=True
in a flow run read and a work pool query to ensure atomic operations (TODO revisit)an assumption im making is that we only need to serialize access when actually changing a work pool's status from NOT_READY to READY - the worker heartbeat upsert itself uses
on_conflict_do_update
(maybe) consider logfire for exploring bottlenecks
i am not suggesting i commit this optional logfire instrumentation as is, though would be open to putting it behind a real flag if we eventually had buy in

related to #16299