Fix duplicate breadcrumb block declaration in partial#204
Merged
Codencode merged 2 commits intoFeb 24, 2026
Conversation
ga-devfront
previously approved these changes
Feb 23, 2026
tblivet
previously approved these changes
Feb 23, 2026
jolelievre
previously approved these changes
Feb 23, 2026
Touxten
previously approved these changes
Feb 23, 2026
Codencode
dismissed stale reviews from Touxten, jolelievre, tblivet, and ga-devfront
via
07e5783
tblivet
requested changes
Feb 24, 2026
tblivet
left a comment
tblivet
left a comment
Contributor
There was a problem hiding this comment.
Thank you @Codencode, that’s good 👍 Just a small naming change regarding my suggestion: I don’t think _wrapper is needed.
Codencode
force-pushed
the
fix/breadcrumb-block-inheritance
branch
from
07e5783 to
26cbf0d
Compare
tblivet
approved these changes
Feb 24, 2026
ingridusta
approved these changes
Feb 24, 2026
ingridusta
left a comment
ingridusta
left a comment
There was a problem hiding this comment.
Hi @Codencode,
Your pr is tested and no regression detected. keyboard nav + links are still functional in the breadcrumb.
It's QA approved ! ✅
Contributor
Author
|
Thank you @ingridusta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{block name='breadcrumb'}in bothlayout-both-columns.tplandbreadcrumb.tpl.