Update qty-input.tpl #680
Open
Update qty-input.tpl #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Ensure provided input attributes take precedence over defaults This commit modifies the Smarty template to prevent default input attributes (e.g., class, name, value) from duplicating attributes that are already defined in the $attributes array. Previously, default attributes were appended after the loop that applied provided attributes, resulting in double values which is break HTML standart. Now, conditional checks are used to only apply default attributes when the corresponding attribute is not already set in the $attributes array.
|
Hello @panariga! This is your first pull request on hummingbird repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
tblivet
requested changes
Mar 10, 2025
Comment on lines
+28
to
+40
| <input | ||
| {foreach $attributes as $key=>$value} | ||
| {$key}="{$value}" | ||
| {$key}="{$value}" | ||
| {/foreach} | ||
| {* The default attributes, will be used if not defined *} | ||
| class="form-control" | ||
| name="qty" | ||
| aria-label="{l s='Quantity' d='Shop.Theme.Actions'}" | ||
| type="text" | ||
| inputmode="numeric" | ||
| pattern="[0-9]*" | ||
| value="1" | ||
| min="1" | ||
| {* End of default attributes *} | ||
| /> | ||
| {if !isset($attributes.class)}class="form-control"{/if} | ||
| {if !isset($attributes.name)}name="qty"{/if} | ||
| {if !isset($attributes['aria-label'])}aria-label="{l s='Quantity' d='Shop.Theme.Actions'}"{/if} | ||
| {if !isset($attributes.type)}type="text"{/if} | ||
| {if !isset($attributes.inputmode)}inputmode="numeric"{/if} | ||
| {if !isset($attributes.pattern)}pattern="[0-9]*"{/if} | ||
| {if !isset($attributes.value)}value="1"{/if} | ||
| {if !isset($attributes.min)}min="1"{/if} | ||
| /> |
There was a problem hiding this comment.
Hello, looks good 👍 but there is a small indent issue.
<input> is not align with <button> and {$key} has an extra indent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Ensure provided input attributes take precedence over defaults
This commit modifies the Smarty template to prevent default input attributes (e.g., class, name, value) from duplicating attributes that are already defined in the $attributes array.
Previously, default attributes were appended after the loop that applied provided attributes, resulting in double values which is break HTML standart.
Now, conditional checks are used to only apply default attributes when the corresponding attribute is not already set in the $attributes array.