Document admin_api_multistore feature flag prerequisite in CONTEXT.md#205
Merged
jolelievre merged 2 commits intoMay 20, 2026
Merged
Conversation
The Multi-shop section described the request-level context parameters and the shopIds DTO convention, but did not mention that multistore support is gated behind the experimental admin_api_multistore feature flag. Without the flag, the shop context parameters are ignored at runtime and the API falls back to single-shop behavior. Add a leading note clarifying the prerequisite so the surrounding conventions are interpreted correctly.
The "Don't expose Value Objects as DTO properties" rule already carved out DecimalNumber as the single exception, but the ApiResourcePropertyTypeRule PHPStan rule also permits DateTimeImmutable for date / datetime properties. Add it to the property naming table and reword the Don't entry to list both exceptions, and reference the PHPStan rule by name so contributors know exactly what's being enforced.
mattgoud
approved these changes
May 20, 2026
github-project-automation
Bot
moved this from Ready for review
to Merged
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Multi-shopsection inCONTEXT.mddescribed:shopId,shopGroupId,shopIds,allShops),shopIdsDTO association property and its mapping conventions,[_context]mapping prefix used to pass shop context into CQRS commands and queries,but did not mention that multistore support in the Admin API is currently gated behind the experimental
admin_api_multistorefeature flag (Advanced Parameters → New & Experimental Features).Without the flag enabled, the shop context parameters described in the section are ignored at runtime and the API falls back to single-shop behavior. Contributors (and AI agents reading this file as the source of truth for the module) need this prerequisite to interpret the conventions correctly.
This PR adds a single leading note at the top of the
Multi-shopsection and a small clarification on the existing "multistore is enabled" paragraph. No other section is touched.A matching documentation update on the public devdocs site is open at PrestaShop/docs#2146.
Test plan
Multi-shopsection inCONTEXT.mdand confirm the prerequisite is stated clearly.