Feat: improve checkout robustness and error recovery#29
Merged
Conversation
- add gift wrapping support - make submit validation state survive reloads and failed submit roundtrips - harden address, carrier, payment and guest flows in the frontend
julienr114
approved these changes
Apr 20, 2026
julienr114
left a comment
There was a problem hiding this comment.
C'est ok, il faut juste fixe le conflict
sylardiere
approved these changes
Apr 21, 2026
kpodemski
reviewed
Apr 27, 2026
b75d010 to
0649076
Compare
0649076 to
0520d6e
Compare
Move shared OPC availability and runtime exception handling to the JSON front controller parent so child controllers only implement their successful request path. Keep opcsubmit thin by delegating failed-submit state persistence to OnePageCheckoutSubmitHandler, including technical reload errors and active cart validation. Remove the ModuleTranslation helper and use the translator contract directly across handlers and checkout form code. Update unit coverage for submit error persistence and controller behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2. Toggle gift wrapping and verify totals and payment availability stay consistent, including after an AJAX failure.
3. Verify address, carrier, payment, and guest flows remain stable after AJAX refreshes and retries.