Skip to content

Feat: improve checkout robustness and error recovery#29

Merged
ThbPS merged 16 commits into
SPE-72/opc-migrationfrom
SPE-108/feat/ui-errors-managment
May 5, 2026
Merged

Feat: improve checkout robustness and error recovery#29
ThbPS merged 16 commits into
SPE-72/opc-migrationfrom
SPE-108/feat/ui-errors-managment

Conversation

@ThbPS
Copy link
Copy Markdown
Collaborator

@ThbPS ThbPS commented Apr 15, 2026

Questions Answers
Description? This PR improves one-page checkout reliability in customer-facing flows. It preserves validation state after failed final submit roundtrips, adds gift-wrapping support to the OPC AJAX flow, and hardens address, carrier, payment, and guest updates so the checkout stays coherent after refreshes, retries, and runtime errors.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? 1. In OPC, submit with missing required fields and verify values and validation errors are restored after reload.
2. Toggle gift wrapping and verify totals and payment availability stay consistent, including after an AJAX failure.
3. Verify address, carrier, payment, and guest flows remain stable after AJAX refreshes and retries.

- add gift wrapping support
- make submit validation state survive reloads and failed submit roundtrips
- harden address, carrier, payment and guest flows in the frontend
@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Apr 15, 2026
@ThbPS ThbPS changed the title feat(opc): improve checkout robustness and error recovery Feat: improve checkout robustness and error recovery Apr 15, 2026
Copy link
Copy Markdown

@julienr114 julienr114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est ok, il faut juste fixe le conflict

Comment thread tests/php/Unit/Checkout/Ajax/OpcAddressFormHandlerTest.php
Comment thread tests/php/Unit/Checkout/Ajax/OpcAddressFormHandlerTest.php
Comment thread src/Checkout/Ajax/Carrier/TempAddressStorage.php Outdated
Comment thread src/Translation/ModuleTranslation.php Outdated
Comment thread controllers/front/giftwrapping.php Outdated
Comment thread controllers/front/opcsubmit.php Outdated
Comment thread controllers/front/opcsubmit.php
Comment thread src/Checkout/Ajax/Submit/OnePageCheckoutSubmitHandler.php Outdated
@kevin-carangeot kevin-carangeot force-pushed the SPE-108/feat/ui-errors-managment branch from b75d010 to 0649076 Compare April 29, 2026 13:23
@dylanDenizonPresta dylanDenizonPresta force-pushed the SPE-108/feat/ui-errors-managment branch from 0649076 to 0520d6e Compare April 29, 2026 13:32
kevin-carangeot and others added 5 commits April 29, 2026 15:33
Move shared OPC availability and runtime exception handling to the JSON front controller parent so child controllers only implement their successful request path.

Keep opcsubmit thin by delegating failed-submit state persistence to OnePageCheckoutSubmitHandler, including technical reload errors and active cart validation.

Remove the ModuleTranslation helper and use the translator contract directly across handlers and checkout form code.

Update unit coverage for submit error persistence and controller behavior.
@ThbPS ThbPS requested a review from kpodemski May 4, 2026 13:57
@ThbPS ThbPS merged commit a7f3f4a into SPE-72/opc-migration May 5, 2026
14 of 16 checks passed
@ThbPS ThbPS deleted the SPE-108/feat/ui-errors-managment branch May 5, 2026 11:05
@github-project-automation github-project-automation Bot moved this from Ready for review to Merged in PR Dashboard May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

6 participants