Fix: missing OPC checkout templates #41
Open
ThbPS wants to merge 1 commit into
Open
Conversation
…arrierExtraContent hook properly to avoid BC in themes
kpodemski
reviewed
May 6, 2026
| * (2 or 3 items — matches CSS modifiers --2 and --3) | ||
| *} | ||
|
|
||
| <div class="form-fields-row form-fields-row--{$fields|count}"> |
Contributor
There was a problem hiding this comment.
Please consider prefixing the class. A rule of thumb is that modules should be more specific in class naming. Why? Because you cannot risk that adding a module would overwrite the style for some other class provided by a theme, etc.
Suggested change
| <div class="form-fields-row form-fields-row--{$fields|count}"> | |
| <div class="psonepagecheckout-form-fields-row psonepagecheckout-form-fields-row--{$fields|count}"> |
please adjust the naming to your preference
kpodemski
reviewed
May 6, 2026
| * For the full copyright and license information, please view the | ||
| * LICENSE.md file that was distributed with this source code. | ||
| */ | ||
| .form-fields-row { |
Contributor
There was a problem hiding this comment.
See the comment below that tacles on naming of the class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updatedDeliveryForm.ps_onepagecheckoutwith the Hummingbird theme, open the checkout page, verify that contact/account sections render correctly for guest and logged-in customers, select a carrier, and complete an order.Related PRs: