feat(coding-agent): select provider before model - #2288
Closed
gurssagar wants to merge 1 commit into
Closed
Conversation
Prime Agent performance — pending-trustPR Waiting for contributor vouch before credentials or sandboxes are allocated. |
|
Hi @gurssagar, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/PrimeIntellect-ai/prime-agent/blob/main/CONTRIBUTING.md for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2287
Summary
Change plain
/modelfrom a flat catalog to provider → model selection. Users can choose their provider first, then search a shorter list containing only that provider's models. Keep/model <query>as the direct-search shortcut.This PR contains only the picker feature. Fast-mode capability and daemon metadata changes are tracked separately in #2286.
User flow
/modelwith no query. See Choose provider and Search providers./model <query>still starts directly in cross-provider model search within the active all/scoped selection. Its first Escape also returns to providers; the next closes. The model query is cleared when entering a provider again.Implementation
Provider grouping, ordering, and search
providers | modelsnavigation state toModelSelectorComponent. Derive providers from the existing model catalog and active scope; add no new provider endpoint.State, keyboard controls, and layout
ConfigurationMenuComponentfooter hints viaisSelectingProvider(): navigation/close at the provider stage, model/effort/back at the model stage.Compatibility and scope
No daemon wire changes. This PR adds no commands, events, capabilities, schema fields, or protocol/schema version changes. It uses existing catalog and configured-provider metadata and preserves the model-selection callback contract.
This does not redesign
/login, merge configuration tabs, alter provider inference code, or change the model catalog. Model-selection completion, busy-state protection, login cancellation, effort retry, and editor draft/focus retention remain covered.The additional provider confirmation and back-then-close behavior are intentional interaction changes, including when entering through direct model search.
Validation
npm run checkpassed (format/lint/types, installer, browser smoke; 1,035 files checked, no fixes).git diff --checkpassed. Validation made no formatter or implementation changes.Run from
packages/coding-agent:Coverage includes grouping/search, provider-restricted callbacks, current selection, direct search, back/close, refresh/empty states, scopes, authentication ordering and fallback, effort/search interaction, failure/retry, draft/focus retention, paging, and viewport limits. The total includes existing regressions, not only newly added tests.
Supplementary earlier installed-component smoke passed both stages, scrolling, and back navigation at 24/80/120 columns × 8/12/24 rows, using fake models/auth and blocked network access. It loaded the installed selector from an isolated unpublished build that also included the separate Fast change. The isolated PR-branch validation above is the feature-only check; the installed smoke is not authenticated end-to-end inference validation.
No real credentials were copied or authenticated inference calls made. Account availability, live login, and provider acceptance remain outside these mock tests.
Note
Add provider-first selection to
ModelSelectorComponentpicker/model <query>still opens straight in model mode and searches across providers.Macroscope summarized de661db.