Fix undefined reference advancex_ - #109
Merged
Merged
Conversation
Collaborator
|
@nferraro can you comment on if you are happy with this change. This is one of the final blockers for the updated build system. |
Collaborator
|
It's fine with me. I don't see advancex defined anywhere so this is probably some vestige from a different branch or debug test. In the former case, that can get resolved whenever it's merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building M3DC1 with branch #97 in Stellar encountered the error with intel compiler:
Since
vspdimsis currently hardcoded, it should be safe to comment out this code for now.There are also some other references to
vspdims.eq.5; some are already commented out, while others are not. Please let me know whether we will never need vspdims == 5, in which case we can remove all of these references, or whether vspdims is expected to be switched manually and the code recompiled when needed.