llvm: Return initialized values as output from "reset" function execution variants. #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Vesely <[email protected]>
Signed-off-by: Jan Vesely <[email protected]>
…ments Signed-off-by: Jan Vesely <[email protected]>
…eIntegrator Increased tolerance is now only needed for fp32 execution. Signed-off-by: Jan Vesely <[email protected]>
Match Python implementations. Signed-off-by: Jan Vesely <[email protected]>
Signed-off-by: Jan Vesely <[email protected]>
The "reset" variants of functions now return a value. Add tests for reset behaviour of: * ProcessingMechanism using an integrator function * DDM mechanism using DriftDiffusionIntegrator function * TransferMechanism in integrator mode The reproducer from PrincetonUniversity#3142 was added as a test of mechanism reset in composition. Fixes: PrincetonUniversity#3142 Signed-off-by: Jan Vesely <[email protected]>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.11): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the value of "previous_value" Parameter in Function "reset" variant for Functions that don't have other Parameters with initializers.
Return the values of "previous_value" and "previous_time" in DriftDiffusionIntegrator "reset" variant".
Update output ports in Mechanism "reset" execution variants, using the value returned from the Function's "reset" variant.
Update tests to allow the selection of execution variants for Mechanisms and Functions.
Add reproducer from #3142 as a regression test.
Closes: #3142