Skip to content

Clarify fork's purpose #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheKodeToad
Copy link
Member

The orginal project links to us for some reason...
but we're really not a good choice for a general purpose NBT reader as we are probably never gonna implement reading SNBT or region files or document things properly

Signed-off-by: TheKodeToad <[email protected]>
@ljfa-ag
Copy link

ljfa-ag commented Jun 22, 2025

Hi, original author of libnbt++ here. I linked to this project since, aside from me personally being a user of PrismLauncher, this fork appears to be the most "up-to-date" one. Although I'm realizing that this doesn't make much sense since, as far as I can tell, the binary NBT format was not changed since the introduction of long array tags in 2017 and so my library should still be compatible (apart from the old cmake version).

I'm going to update my readme and remove the link to this repo.

@TheKodeToad
Copy link
Member Author

TheKodeToad commented Jun 22, 2025

We do have a crash fix and an active team of maintainers (so linking to us isn't useless), but I just thought it was important to clarify this as some people were asking for new features but we don't really have any reason to implement them ourselves.

Well, I would assume:

  • new features even if someone opens a pr for them might not even be merged
  • bug fixes even if they don't affect the launcher probably would be

but that's just my feeling

@ljfa-ag
Copy link

ljfa-ag commented Jun 22, 2025

I see, then I will still keep a link. I wanted to unarchive the repo, fix the CMake build and edit the readme anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants