-
Notifications
You must be signed in to change notification settings - Fork 1
Convert Settings page to interactive tasks #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Test on Playground |
|
The "Set valuable post types" task is also converted to be interactive. Task will be added again if the new public post type is detected. I think there is no need to add it when public post type is removed since that means there will just be one less checkbox to be selected, which doesn't give user any other option than confirming the current selection (also it might be confusing, if user doesn't realize that one post type is now missing). Since "Set pages" and "Set valuable post types" are now interactive tasks the only option on that page is "Default login destination". If we move it to the PP dashboard page, maybe create a button (next to the Tour and Registration) which triggers popover with that option? If we do that, should we remove Settings Page completely and "Fill the Settings Page" task as well? EDIT: |
✅ Code Coverage Report
📊 File-level Coverage Changes (5 files)🆕 New Files
📉 Coverage Decreased
ℹ️ About this report
|
This PR converts settings from Settings page to interactive tasks, as much as possible.
It is still WIP but set About, Contact and FAQ page settings are converted - the choices user has are the same:
All 3 tasks share same codebase, but we can adjust popover to recommend user to install Contact form or any other feature.
Things left to implement (from Slack discussion):
Detect if site has home page set and auto assign it (no need for user to do it)We already do this