map cosmetic type to microtransaction category#142
Merged
lvlvllvlvllvlvl merged 1 commit intoNov 16, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Ensure that
cosmetic_typefield does not cause errors and allows items to be categorized correctlyAction Taken
As mentioned in #104 (comment), the data in CosmeticTypeName does not precisely match the previous data that was exported in the
cosmetic_typefield. Heuristics are employed to match the previous format, and acosmetic_targetfield is added to contain more specific data when available.CosmeticTypeNamevalues are mapped to specificcosmetic_typeandcosmetic_targetvaluesCaveats
CosmeticTypeNameis not very clean; several apparent typos have been worked around with manual mappings