Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for export wildcard module syntax #613

Merged
merged 2 commits into from
May 27, 2021
Merged

added support for export wildcard module syntax #613

merged 2 commits into from
May 27, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented May 22, 2021 •
edited
Loading

Related Issue

resolves #612

_Can see this working with Lit@2 over in #611 _

Summary of Changes

  1. Added support ExportAll declarations when walking modules in package.json
  2. Refactor updating importMap to a single function and bare import fallback support

This is just a stop gap, ideally would like to be able to delegate this all to NodeJS somehow - #557

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels May 22, 2021
@thescientist13 thescientist13 mentioned this pull request May 22, 2021
Merged
12 tasks
@thescientist13 thescientist13 merged commit 9496c94 into master May 27, 2021
@thescientist13 thescientist13 deleted the bug/issue-612-export-wildcard-syntax-support branch May 27, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI is not handling export * ... (wildcard) export formats
1 participant
@thescientist13