-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling puppeteer serialization issues with lit 2 and Shady DOM #719
Merged
thescientist13
merged 4 commits into
enhancement/upgrade-website-lit-2-support
from
bug/issue-675-puppeteer-declarative-shadow-dom-support
Sep 22, 2021
Merged
handling puppeteer serialization issues with lit 2 and Shady DOM #719
thescientist13
merged 4 commits into
enhancement/upgrade-website-lit-2-support
from
bug/issue-675-puppeteer-declarative-shadow-dom-support
Sep 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
46b63cd
to
9cafbec
Compare
8127cf1
to
6a001d9
Compare
5 tasks
Hmm, not sure what's up with this build failure / stalling in Windows. prerendering page... /
prerendering page... /plugins/context/
prerendering page... /plugins/custom-plugins/
prerendering page... /plugins/
prerendering page... /plugins/resource/
prerendering page... /plugins/rollup/
prerendering page... /plugins/server/
(node:4368) UnhandledPromiseRejectionWarning: Error: EBUSY: resource busy or locked, copyfile 'D:\a\greenwood\greenwood\node_modules\@webcomponents\webcomponentsjs\bundles\webcomponents-sd-ce-pf.js' -> 'D:\a\greenwood\greenwood\public\bundles\webcomponents-sd-ce-pf.js'
prerendering complete for page /about/goals/.
(Use `node --trace-warnings ...` to show where the warning was created)
prerendering complete for page /about/how-it-works/.
(node:4368) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
prerendering complete for page /about/features/.
(node:4368) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
prerendering complete for page /docs/configuration/.
prerendering complete for page /about/.
prerendering complete for page /docs/component-model/.
prerendering complete for page /docs/css-and-images/. Tested on a Windows VM and everything was fine, so I guess some sort of race condition? Only thing I can think of is [here in plugin-polyfills maybe there are some await Promise.all(polyfillFiles.map(async (file) => {
const from = path.join(cwd, nodeModuleRoot, file);
const to = path.join(outputDir, file);
return !fs.existsSync(to)
? fs.promises.copyFile(from, to)
: Promise.resolve();
})); |
8 tasks
thescientist13
added a commit
that referenced
this pull request
Sep 23, 2021
* WIP * revert www changes * apply lit polyfill support * conditially check for lit before using polyfill
thescientist13
added a commit
that referenced
this pull request
Oct 6, 2021
* init commit with website components working use lit 2 * update import node modules spec per new lit packaging * disable SPA mode spec * all specs passing with new lit * update cli devDep * everything working and rebased * restore eve components * add trusted types scaffolding for lit-html * upgrade to latest version of lit-redux-router with lit 2 compat * update specs * update develop specs for lit@2 * upgrade lit rc4 * handling puppeteer serialization issues with lit 2 and Shady DOM (#719) * WIP * revert www changes * apply lit polyfill support * conditially check for lit before using polyfill * upgrade to final stable version * rebased from master but broken??? * bump deps and set lit resolututions * ship lit polyfill for lit and plugin polyfills users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #675, and fixes the critical TODOs from #611
Summary of Changes
TODO
Summary of Changes
Also, not sure why path to evergreen.svg is unhappy now on nested routes?
![Screen Shot 2021-09-07 at 5 08 50 PM](https://user-images.githubusercontent.com/895923/132411204-d840586d-0c77-40f6-949f-8f853b724731.png)