Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor eve-button as temp fix for flashing styles as text #753

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 7, 2021

Related Issue

the quick fix for #752 (long term fix to come after more analysis)

Summary of Changes

  1. Vendored eve-button and changed to use Lit's styles API
  2. Opened leverage Lit's styles API for component styles hutchgrant/evergreen-web-components#36 for long term solution

Will fix this more thoroughly in another PR, just want to fix the home page for now, so will leave #752 open for further discussion

@thescientist13 thescientist13 added website Tasks related to the projects website / documentation P0 Critical issue that should get addressed ASAP labels Oct 7, 2021
@thescientist13 thescientist13 merged commit fb252d6 into master Oct 8, 2021
@thescientist13 thescientist13 deleted the website/issue-752-vendor-eve-button-temp-fix-styles-text-flash branch October 8, 2021 14:56
@thescientist13
Copy link
Member Author

I'll make sure we chat about this on the next weekly call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical issue that should get addressed ASAP website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

website home page banner briefly flashing inline styles as text on page load when prerendering (SSG / MPA)
2 participants