Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/issue 88 header navigation using content as data #122

Merged
merged 3 commits into from
Oct 31, 2024
Merged

enhancement/issue 88 header navigation using content as data #122

merged 3 commits into from
Oct 31, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 28, 2024 •
edited
Loading

Related Issue

resolves #88

Summary of Changes

  1. Pull header navigation from content as data using a navigation collection
  2. Add active link underline styles

TODO

  1. Tests will fail until Docs Page #31 is merged (then will need to add docs to the collection, which should fix the ordering)
  2. Should get merged after chore/upgrade greenwood v0.30.0 alpha.7 #107 to account for latest Content as Data API changes

@thescientist13 thescientist13 added the enhancement New feature or request label Oct 28, 2024
@thescientist13 thescientist13 self-assigned this Oct 28, 2024
@thescientist13 thescientist13 added the invalid This doesn't seem right label Oct 28, 2024
@thescientist13 thescientist13 changed the title Enhancement/issue 88 header navigation using content as data enhancement/issue 88 header navigation using content as data Oct 28, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit ab88084
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/6723bb6ebd533400083ed64b
😎 Deploy Preview https://deploy-preview-122--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 force-pushed the enhancement/issue-88-header-navigation-using-content-as-data branch from 1d0522d to ab88084 Compare October 31, 2024 17:16
@thescientist13 thescientist13 removed the invalid This doesn't seem right label Oct 31, 2024
@thescientist13 thescientist13 merged commit 0f6fdca into main Oct 31, 2024
5 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-88-header-navigation-using-content-as-data branch October 31, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

leverage content as data for the header component navigation content
1 participant
@thescientist13