Use --strict build flag to avoid publishing errors#89
Merged
Conversation
Contributor
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Member
Author
|
@mattsl21 Just a heads up, when we merge this PR, the builds will fail if there are any errors in the notebooks. That can be annoying during rapid development but is a better solution for long-term health testing. It will also mean that we don't accidentally publish bad results from nightly tests for the appendix notebook that streams ERA5 data, which occasionally fails due to network issues. |
Member
Author
|
I spoke directly with Matt about this and he is on board. I will merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the build command from the current default
to
This means that errors in the notebooks will cause the myst build to fail. As a consequence, we will not publish rendered book pages containing errors in the Python code.