fix: consolidate auth/role/admin guard implementations#50
Merged
MaryammAli merged 2 commits intoJun 23, 2026
Merged
Conversation
- Export AuthenticatedUser interface as canonical user shape for both HTTP and WS - Fix WsJwtGuard to map JWT sub claim to id field (canonical shape) - Add RolesGuard unit tests covering player/admin access and exact enum comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Consolidates duplicate guard implementations and enforces a single canonical authenticated user shape across HTTP and WebSocket paths.
Type of Change
🎯 Requirements Checklist
Implementation
Security
Testing
📝 Detailed Changes
Added
AuthenticatedUserinterface exported fromauth/interfaces/request-with-user.tsas the single canonical user shape for both HTTP and WebSocket pathsUpdated
WsJwtGuardnow maps raw JWTsubclaim →idfield, aligning the WS user shape with the HTTP path (RequestWithUser)Added
roles.guard.spec.ts— unit tests covering player access, admin access, player denied from admin route, and exact enum comparison guard🧪 Testing Instructions
Steps to Verify
npm run build— must pass with no errorsnpx jest --testPathPattern="roles.guard|admin.guard"— all 13 tests must passExpected Results
Build succeeds; 13 guard tests green.
🔗 Related Issues
Closes #16
📚 Documentation