Add Comet search engine #3341
Merged
Add Comet search engine #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch engine changes (based on SearchEngine.[Precursor|Fragment]IonToleranceUnitTypes)
I'll build and test manually. |
|
@chambm yeah, it's good, thanks |
* added types and value clamping for most Comet AdditionalSettings * added support for choosing fragment ions in Comet from main settings dialog
…zard/pwiz into Skyline/work/20240809_add_Comet
…zard/pwiz into Skyline/work/20240809_add_Comet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bspratt I changed mass tolerance combobox population so it happens after search engine initialization. Since Hardklor presumably needs those too, I had to remove one of those
if (ImportPeptideSearch.IsFeatureDetection) return;statements. The FeatureDetectionTutorial still seemed to run ok, but I didn't do much extra testing.