-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "View > Live Reports" and "View > Libraries" references in English tutorial HTML files. #3396
Update "View > Live Reports" and "View > Libraries" references in English tutorial HTML files. #3396
Conversation
…lish tutorial HTML files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Need to remove ... in menu item names.
@@ -673,7 +673,7 @@ <h1>Quantitative comparison </h1> | |||
To perform a simple pairwise group comparison inside Skyline do the following: | |||
</p> | |||
<ul> | |||
<li>On the <b>View</b> menu, choose <b>Other Grids</b>, then <b>Group Comparison</b>, and click <b>Add</b>.</li> | |||
<li>On the <b>View</b> menu, choose <b>Live Reports</b>, then <b>Group Comparisons</b>, and click <b>Add...</b>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't include the ... Changing that now everywhere would be much more work, especially since Chinese use a different ...
@@ -668,7 +668,7 @@ <h1>Quantitative comparison </h1> | |||
To perform a simple pairwise group comparison inside Skyline do the following: | |||
</p> | |||
<ul> | |||
<li>On the <b>View</b> menu, choose <b>Other Grids</b>, then <b>Group Comparison</b>, and click <b>Add</b>.</li> | |||
<li>On the <b>View</b> menu, choose <b>Live Reports</b>, then <b>Group Comparisons</b>, and click <b>Add...</b>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No ...
@@ -666,7 +666,7 @@ <h1>Quantitative comparison </h1> | |||
To perform a simple pairwise group comparison inside Skyline do the following: | |||
</p> | |||
<ul> | |||
<li>On the <b>View</b> menu, choose <b>Other Grids</b>, then <b>Group Comparison</b>, and click <b>Add</b>.</li> | |||
<li>On the <b>View</b> menu, choose <b>Live Reports</b>, then <b>Group Comparisons</b>, and click <b>Add...</b>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No ...
I am the creator of the tutorial style and generally the person who has had to review and correct where other writers deviate. I created the style in 2009 when I wrote the first Method Edit tutorial by reading a Microsoft tutorial at the time. Can't remember if it was from Office of Visual Studio. I can't say for sure whether that tutorial had the keyboard shortcuts or I just started adding them as I added them to Skyline and felt they were useful for people to know. The "Ctrl+C" style definitely seems like the standard now. I would not be opposed to a PR that switched all of our keyboard shortcuts to that style. You can definitely still find "Ctrl-C" on the web if you search for it. Google AI has this to say: "The transition from "Ctrl-C" to "Ctrl+C" as a standard keyboard shortcut for copy (and other functions) occurred gradually, with the "Ctrl+C" format becoming prevalent in the 1980s and 1990s, particularly with the rise of Windows and Macintosh operating systems." So, it seems likely the older style came from my own head as someone who started using a Mac in 1984 and testing Excel on Windows in 1990. |
I found and fixed all the places in the "index.html" tutorial HTML files that mentioned menu items that have been moved to the "View > Live Reports" or "View > Libraries" sub-menus.
I also changed it so that they all mention the accelerator if it exists for example:
On the <b>View</b> menu, choose <b>Live Reports</b>, and click <b>Document Grid</b> (Alt-3).
I wonder why we have standardized on using a hyphen in "Alt-3" instead of a plus sign "Alt+3".
The text in the menus always has a "+".