More constant propagation and folding.#28520
Merged
mikebenfield merged 1 commit intomainnetfrom Mar 6, 2025
Merged
Conversation
Collaborator
|
Could we add a test to propagate literal values including addresses? |
mikebenfield
force-pushed
the
expand-const-prop
branch
from
559dffd to
5d28fb6
Compare
Contributor
Author
|
See the test |
d0cd
reviewed
Mar 6, 2025
d0cd
approved these changes
Mar 6, 2025
Collaborator
d0cd
left a comment
d0cd
left a comment
There was a problem hiding this comment.
LGTM! Left a minor nit for a more verbose error message.
Const propagate address, array, and struct literals, and fold array, struct accesses, and tuple accesses when possible. Fixes #28519
mikebenfield
force-pushed
the
expand-const-prop
branch
from
6d4734f to
88002bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Const propagate address, array, and struct literals, and fold array and struct accesses when possible.
Fixes #28519