Fix Tests in Simulator#28
Open
zkclay wants to merge 4 commits into
Open
Conversation
TToDOg5
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all, I was taking a look at your testing approach for Aleo programs, and I wanted to contribute my first PR!
In this PR, I made a few different changes in order to for all the tests to pass in the simulator projects. I have summarized the the changes below:
simulator/src/contracts/pondoProgramsIndex.tsin order to track the renaming that was done in previous commits.initialize only oncetest was present in the leo program, but not the javascript.JSON.stringifyon the struct, but was decoded using.to_string(), resulting in the key not being found.toSpliced(rank, 1)what throwing errors in my environment becuase it is newer javascript syntax, i replicated the functionality using older syntax.