Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deps] Update snarkVM with the new aleo-std and test storage setup #3535

Merged
merged 4 commits into from
Mar 25, 2025
Merged

[Deps] Update snarkVM with the new aleo-std and test storage setup #3535

merged 4 commits into from
Mar 25, 2025

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Mar 12, 2025

Based on ProvableHQ/snarkVM#2590.

Publishing as a draft until the snarkVM counterpart is merged.

@vicsn vicsn requested review from raychu86 and vicsn March 12, 2025 21:25
@ljedrz ljedrz force-pushed the deps/update_snarkvm branch from cbc8941 to 02782a1 Compare March 24, 2025 16:17
niklaslong
niklaslong previously approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@niklaslong niklaslong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@niklaslong
Copy link
Collaborator

The CI failure is likely because of ProvableHQ/snarkVM#2631. @ljedrz, since you're already updating VM in this PR, could you increase the rw message queue as a fly-by? 🙏

@ljedrz ljedrz marked this pull request as ready for review March 24, 2025 20:25
@ljedrz
Copy link
Collaborator Author

ljedrz commented Mar 24, 2025 •
edited
Loading

@niklaslong done, and I included cargo update, so this renders #3518 redundant in staging if this PR goes in first.

@ljedrz
Copy link
Collaborator Author

ljedrz commented Mar 24, 2025

The devnet job might be a fluke (compilation timeout), but I currently don't have the rights to re-run it.

@niklaslong
Copy link
Collaborator

niklaslong commented Mar 25, 2025 •
edited
Loading

Let's see. Looks like the failure might be related to the breakage we've seen on circle's new container runtime.

this renders #3518 redundant in staging if this PR goes in first.

We might want ProvableHQ/snarkVM#2624 in before this one as well, in that case?
Edit: now merged.

@ljedrz
Copy link
Collaborator Author

ljedrz commented Mar 25, 2025

Better not as we would then need to rebase this one 😄.

@niklaslong
Copy link
Collaborator

We can bump the rev in a subsequent PR as well 👍

niklaslong
niklaslong previously approved these changes Mar 25, 2025
View reviewed changes
@niklaslong niklaslong merged commit 2f67d2d into ProvableHQ:staging Mar 25, 2025
2 checks passed
@kpandl kpandl mentioned this pull request Mar 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklaslong niklaslong

@raychu86 raychu86

@vicsn vicsn

Assignees
No one assigned
Labels
v3.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljedrz @niklaslong