Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept: Control game speed with right thumbstick #1401

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

DanEEStar
Copy link

What does this PR do

By steering the xAxis of the right thumbstick the player can control
the game speed of the emulator directly.
Press "right" -> GameSpeed.fast
Press "left" -> GameSpeed.slow
Neutral position -> GameSpeed.normal

This is basically just a proof of concept. But maybe someone has the same problems as I had...

Where should the reviewer start

I don't know if this makes sense to merge...

How should this be manually tested

Any background context you want to provide

I recently started playing some older JRPGs in Provenance like Dragon Quest 1 and Final Fantasy VI. The battles especially in the beginning, can become very boring. You basically just have to press "Attack" and wait...
Also manually changing the Game Speed via the menu became boring fast...

So my idea was to map the Game Speed control to some, often unused, buttons on my XBOX-Gamepad. So I mapped the GameSpeed to the right thumbstick.

With this small change I can control the Game Speed in game directly with the controller.

What are the relevant tickets

Screenshots (important for UI changes)

Questions

By steering the xAxis of the right thumbstick the player can control
the game speed of the emulator directly.
Press "right" -> GameSpeed.fast
Press "left" -> GameSpeed.slow
Neutral position -> GameSpeed.normal
@jasarien
Copy link
Member

Interesting idea. Not sure it should be merged in its current form though, as it might interfere with cores that use the right stick in their controller layer (PSX and n64 come to mind, initially...).

Maybe it could be morphed into a setting-controlled feature that can be turned off and on in the settings, and maybe further do it on a core by core basis?

Copy link
Member

@jasarien jasarien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my previous comment.

@urherenow
Copy link
Contributor

First, I'd like to say that this is sorely needed. Just from playing Metroid, and I've played it hundreds of times, I can say with 100% certainty that NES emulation is actually too fast on my iPAD and on my iPhone. Sure it may be a core issue, but this feature would certainly allow for correction.

In line with the settings suggestion above, I would like to add that it should be controlled with a slider, default emulation speed being center.

@JoeMatt JoeMatt force-pushed the develop branch 4 times, most recently from 6209b0b to 501aeb5 Compare December 15, 2021 10:53
@JoeMatt JoeMatt force-pushed the develop branch 2 times, most recently from a789cf0 to f0c3e73 Compare November 13, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants