Bug/ios icloud not syncing #2395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc to find undownloaded files and download them and send a notification so roms can be imported
…ded; fixed wrong notification observing
…on crash that occurs when realm is being used by the different iCloud syncing that causes the crash
…g convention; removed importing from app delegate; added TODOs
…s when saving save states on realm
…ith iCloud due to realm
…shes downloading insetad of checking in a loop; updated to import only roms and just download any extra files that are part of the ROMs directory for each core; updated to make the syncers live for the lifetime of the application; added concurrency for downloading files to speed things up; refactored saved states code to just work directly with downloaded files; removed unused events
…ed destination url variable; updated logic to check importer is NOT processing and NOT paused; updated guard to check if file exists
…tialized before trying to download/process ROMs/Saves because we want to use the game cache to speed things up and not hit the db so much;
…how pending to process;
…to 1; updated some logs to information; updated icloud container identifier to use build variable
…of 5 seconds to avoid hangs that still occur even on background thread
…ed unused code; updated to process saves as they come in;
…y for storing in a bucket to process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Where should the reviewer start
How should this be manually tested
Any background context you want to provide
What are the relevant tickets
Screenshots (important for UI changes)
Questions