-
Notifications
You must be signed in to change notification settings - Fork 5
feat(example): validate React Native 0.86 #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kherembourg
wants to merge
6
commits into
feat/sdk-v6-migration
Choose a base branch
from
feat/react-native-0-86
base: feat/sdk-v6-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9812a48
chore: ignore local worktrees
kherembourg a568609
docs: add React Native 0.86 validation design
kherembourg 13dec2a
docs: add React Native 0.86 implementation plan
kherembourg fd03fed
feat(example): validate React Native 0.86
kherembourg c3700bf
ci: validate React Native 0.86
kherembourg 0defa31
ci: allow manual React Native validation
kherembourg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| # OSX | ||
| # | ||
| .DS_Store | ||
| .worktrees/ | ||
|
|
||
| # XDE | ||
| .expo/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # React Native 0.86 Validation Implementation Plan | ||
|
|
||
| > **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking. | ||
|
|
||
| **Goal:** Make React Native 0.86 a supported, New-Architecture-validated v6 sample. | ||
|
|
||
| **Architecture:** The existing RN 0.86 test project is aligned with the local workspaces and RN 0.86 tooling, enables New Architecture, and exposes fullscreen and embedded screens. Android and iOS CI builds verify bridge/ViewManager interoperability; runtime-only cases have a manual checklist. | ||
|
|
||
| **Tech Stack:** React Native 0.86, TypeScript, Gradle, CocoaPods, Xcode, GitHub Actions. | ||
|
|
||
| **Enhanced:** 2026-07-14 | ||
| **Reviewed:** 2026-07-14 | ||
| **Completed:** 2026-07-14 | ||
|
|
||
| --- | ||
|
|
||
| ### Task 1: Restore the RN 0.86 compatibility sample | ||
|
|
||
| **Files:** | ||
| - Modify: `test-projects/rn-purchasely-test/package.json`, lockfile, Android and iOS project configs, `App.*` | ||
|
|
||
| - [x] Replace published v5 dependencies with local v6 workspace packages, align RN toolchain dependencies to 0.86, and enable New Architecture. | ||
| - [x] Add explicit fullscreen and embedded `PLYPresentationView` routes plus test notes for modal, keyboard, safe-area, edge-to-edge, and rotation. | ||
| - [x] Run `npm ci`, Android debug assembly, and unsigned iOS Debug build; commit with `feat(example): validate React Native 0.86`. | ||
|
|
||
| ### Task 2: Run the sample in CI | ||
|
|
||
| **Files:** | ||
| - Modify: `.github/workflows/ci.yml` | ||
|
|
||
| - [x] Add Android and iOS build jobs for `test-projects/rn-purchasely-test` after local package preparation. | ||
| - [x] Retain existing RN 0.79 example coverage until the migration branch changes its primary sample. | ||
| - [x] Validate YAML and commit with `ci: validate React Native 0.86`. |
7 changes: 7 additions & 0 deletions
7
docs/superpowers/specs/2026-07-14-react-native-0-86-design.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # React Native 0.86 Validation Design | ||
|
|
||
| **Scope:** React Native SDK only; branch targets `feat/sdk-v6-migration`. | ||
|
|
||
| The existing React Native 0.86 test project will become the compatibility sample. It will consume local v6 packages, align its tooling with RN 0.86, enable the New Architecture, and build on Android and iOS in CI. The sample will explicitly expose fullscreen and embedded `PLYPresentationView` validation paths. | ||
|
|
||
| Because the SDK uses the classic bridge and view manager, no TurboModule migration is implied. Modal, keyboard, safe-area, edge-to-edge, and rotation validation will be automated when deterministic and otherwise captured in a concise manual test checklist. No public API change is planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| module.exports = { | ||
| root: true, | ||
| extends: ['@react-native'], | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-rn-0-86-androidThe existing
build-androidjob uses bothgradle/actions/setup-gradle@v5(with built-in Gradle cache) and an explicitactions/cache@v4for~/.android/build-cache. The newbuild-rn-0-86-androidjob has neither, so it will re-download and recompile Gradle wrapper and all Android dependencies from scratch on every run, significantly increasing CI time.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!