Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#137 pending sponsoring #168

Merged
merged 14 commits into from
Apr 5, 2020
Merged

Conversation

samsagaz
Copy link
Collaborator

Bueno, como no tuve respuesta del issue #137 , lo mando igual, así agitamos y sigo haciendo otras cosas.

Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que bueno che!! Ahí agregué algunos comentarios por detalles. Pero sí faltan tests!

Gracias!!!

website/events/tests.py Show resolved Hide resolved
website/events/models.py Outdated Show resolved Hide resolved
website/events/migrations/0010_auto_20200225_2153.py Outdated Show resolved Hide resolved
website/events/helpers/sponsoring_pending.py Outdated Show resolved Hide resolved
website/events/helpers/sponsoring_pending.py Outdated Show resolved Hide resolved
website/events/helpers/sponsoring_pending.py Outdated Show resolved Hide resolved
@samsagaz samsagaz requested a review from facundobatista March 3, 2020 10:45
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola! Perdón por la demora en revisar esto...

Te anoté un par de detalles (principalmente un sort que se hace N veces), pero ya estaríamos para landearlo...

Gracias!

website/events/helpers/sponsoring_pending.py Outdated Show resolved Hide resolved
website/events/helpers/sponsoring_pending.py Outdated Show resolved Hide resolved
@samsagaz samsagaz requested a review from facundobatista March 29, 2020 23:10
@facundobatista facundobatista merged commit aed1c09 into PyAr:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants