Skip to content

fix(schedule): break headline location reads venue, not first audience room #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobCoffee merged 1 commit into from
May 1, 2026
Merged

fix(schedule): break headline location reads venue, not first audience room #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/app/providers/conference-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ export class ConferenceData {
// For plenary-like slots, extract room from parentheses in the title
// and strip redundant track prefix (e.g., "Keynote — " since the badge shows it)
var sessionLocation = slot.room;
var displayLocationOverride: string | null = null;
const plenaryKinds = ['plenary', 'keynote', 'lightning-talks', 'event'];
if (plenaryKinds.includes(slot.kind)) {
const roomMatch = slot.name.match(/\s*\(([^)]+)\)\s*$/);
Expand All @@ -358,6 +359,26 @@ export class ConferenceData {
// Strip track prefix like "Keynote — ", "Keynote: " from name since badge shows it
const trackPrefix = new RegExp('^' + slot.kind.replace(/-/g, '[- ]') + '\\s*[—:\\-–]\\s*', 'i');
slot.name = slot.name.replace(trackPrefix, '').trim();
} else if (slot.kind === 'break') {
// Break slots fan out to every audience room (Grand Ballrooms, 103ABC,
// 104AB, etc. — attendees in each room see "break time"). But the
// headline location displayed in the schedule timeline should be the
// single venue where the break service actually happens, e.g.
// "Expo Hall AB" (coffee/snacks). Pull that out of the parenthesized
// suffix in the slot name when present, so a slot with content
// "Break (Expo Hall AB)" / "Coffee (Hall AB)" displays the right
// place — but leave session.location (the comma-joined room list)
// untouched so the per-room fanout still registers the slot in
// every room's room-detail view.
const roomMatch = slot.name.match(/\s*\(([^)]+)\)\s*$/);
if (roomMatch) {
let displayRoom = roomMatch[1].trim();
if (/^Hall\s/i.test(displayRoom)) {
displayRoom = `Expo ${displayRoom}`;
}
displayLocationOverride = displayRoom;
slot.name = slot.name.replace(roomMatch[0], '').trim();
}
}

// Flag Spanish-language sessions and strip "En Español" from title
Expand Down Expand Up @@ -395,14 +416,15 @@ export class ConferenceData {
}
}

var session = {
var session: any = {
"name": slot.name,
"color": this.slotColors[slot.kind],
"preRegistered": slot.preRegistered,
"isSpanish": isSpanish,
"listRender": slot.list_render,
"section": slot.section,
"location": sessionLocation,
"displayLocationOverride": displayLocationOverride,
"description": slot.description,
"speakers": [],
"speakerNames": slot.authors,
Expand Down Expand Up @@ -677,7 +699,12 @@ export class ConferenceData {
// fanout above relies on it). For the schedule timeline we show
// only the first room — wide multi-room labels for breaks/lunch
// wrapped onto multiple lines and looked terrible.
session.displayLocation = links.length > 0 ? links[0].name : (session.location || '');
// displayLocationOverride wins when set (break slots use it to
// surface the venue where service actually happens — e.g. coffee
// is in Expo Hall AB even though the break is registered against
// every audience room).
session.displayLocation = session.displayLocationOverride
|| (links.length > 0 ? links[0].name : (session.location || ''));
});
roomMap.forEach((room: any) => {
room.sessions.sort(
Expand Down
Loading