-
Notifications
You must be signed in to change notification settings - Fork 447
Python 3.14 build #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0x78f1935
wants to merge
9
commits into
PyMySQL:main
Choose a base branch
from
0x78f1935:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Python 3.14 build #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
- Coverage 88.86% 88.84% -0.02%
==========================================
Files 7 7
Lines 548 556 +8
==========================================
+ Hits 487 494 +7
- Misses 61 62 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…detection) that expects a TypeError when unpickling a custom exception, but in Python 3.14, the exception is now picklable, causing the assertion to fail.
Author
|
Even while downgrading back to the default "LTS" tests, the tests fail. But |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not intend to change
"to'in certain cases but my IDE insisted.Why this PR?
I've decided to upgrade my Django stack from Python
3.13.3to3.14.0and this package is one of those packages which have not been updated yet to support Python 3.14.0.Solution?
I've compiled mysqlclient.whl for my windows system running Python
3.14.0, Django5.2.7and MariaDB C Connector3.4.7dist.zip and it works.
I've bumped versions in the CI/CD Pipeline in the hopes the pip issue will resolve once the correct build for the mysqlclient wheel package is available on pip. However, it seems to me that the Pipeline is not responsible for publishing to PyPi.