Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove water sourced heat pumps (for now) #196

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

amos-schledorn
Copy link
Contributor

Currently, we assume data for water-sourced heat pumps from the upper uncertainty range in DEA tables, as recommended by DEA for standalone units.
This

  • breaks optimistic/pessimistic scenarios
  • is likely an overestimate of costs (see e.g. Pieper 2019 who assume all water-sourced heat pumps to be (per MW) cheaper than air-sourced heat pumps)

Changes proposed in this Pull Request

  • Remove water-sourced heat pumps (at least for now) to prevent breaking code for optimistic/pessimistic scenarios

Recommendation

From the currently available data, excess-heat sourced heat pumps could deliver good estimates for water-sourced heat pumps. See also DEA tables on seawater-sourced heat pumps.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

reccomendation: use excess-heat-sourced heat pump data instead or see related DEA data on seawater-sourced heat pumps
@amos-schledorn amos-schledorn changed the title Remove water sourced heat pumps (for now) fix: remove water sourced heat pumps (for now) Mar 26, 2025
Copy link
Contributor

@toniseibold toniseibold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks good to me - optimistic/pessimistic cost horizon run smoothly now

Copy link

@cpschau cpschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@amos-schledorn amos-schledorn merged commit 77c1f14 into master Mar 27, 2025
3 checks passed
@amos-schledorn amos-schledorn deleted the remove-water-sourced-heat-pumps branch March 27, 2025 08:58
@amos-schledorn
Copy link
Contributor Author

Thanks for the reviews @toniseibold @cpschau!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants