-
-
Notifications
You must be signed in to change notification settings - Fork 479
feat: adding missing parameters and attribute documentation #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lumabots <[email protected]>
add missings docs Signed-off-by: Lumabots <[email protected]>
Signed-off-by: Lumabots <[email protected]>
Signed-off-by: Lumabots <[email protected]>
Signed-off-by: Lumabots <[email protected]>
Signed-off-by: Lumabots <[email protected]>
Signed-off-by: Lumabots <[email protected]>
Signed-off-by: Lumabots <[email protected]>
Signed-off-by: Lumabots <[email protected]>
removal of all the nsfw mention which should not exist for category Signed-off-by: Lumabots <[email protected]>
Signed-off-by: Lumabots <[email protected]>
sorry i renamed the branch and it deleted the other one |
Signed-off-by: Lumouille <[email protected]>
Co-authored-by: plun1331 <[email protected]> Signed-off-by: Lumouille <[email protected]>
Co-authored-by: plun1331 <[email protected]> Signed-off-by: Lumouille <[email protected]>
… unsupported nsfw for categories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request title is also misleading.
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Lumouille <[email protected]>
…action_emoji to be None
if you have a better name in mind i'll be happy to change it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix markdown
This pull request isn't a documentation change. |
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Lumouille <[email protected]>
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Lumouille <[email protected]>
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Lumouille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -55,6 +55,8 @@ These changes are available on the `master` branch, but have not yet been releas | |||
([#2714](https://github.com/Pycord-Development/pycord/pull/2714)) | |||
- Added the ability to pass a `datetime.time` object to `format_dt`. | |||
([#2747](https://github.com/Pycord-Development/pycord/pull/2747)) | |||
- Added various missing channel parameters and allow `default_reaction_emoji` to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can specify explicitly what you added but tbf idc that much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can specify explicitly what you added but tbf idc that much
did it in a previous commit but it was too big so they told me to shorten it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this is fine
Summary
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.