refactor: ♻️ update deprecated usage to use typing.deprecated
#2828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paillat-dev
commented
Jul 13, 2025
| @@ -283,16 +282,15 @@ def decorator(overridden: T) -> T: | |||
| return decorator | |||
|
|
|||
|
|
|||
| def warn_deprecated( | |||
| def deprecated_message( | |||
There was a problem hiding this comment.
The git diff makes it look like warn_deprecated was removed, but it wasn't see below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1917
Redo of #2655
The previous version of the PR did not work correctly with type checkers, this one does, with the compromise of needing to use the
@deprecated(deprecated_message(...))syntax. This allows for type checkers to mark methods as deprecated and do some kind of strike trough like shown below:Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.