Skip to content

Fix transaction certificates in Conway and handle latest cardano-cli transaction commands #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2025

Conversation

KINGH242
Copy link
Contributor

@KINGH242 KINGH242 commented Jun 3, 2025

This pull request introduces 3 small but crucial fixes.

Certificates type in TransactionBody:

  • Modified the certificates field in the TransactionBody class to accept either a List or a NonEmptyOrderedSet of Certificate objects, providing compatibility with the various ways transactions can be generated.

Cardano-cli Transaction submission:

  • Enhanced the cardano-cli transaction submit method command by attempting to use the latest prefix for compatability with the latest versions with fallback to the original command.

Python version compatibility:

  • Added a new utility function greater_than_version in pycardano/utils.py to check if the current Python version is greater than or equal to a specified version. This is used to conditionally import and utilize the member attribute from the enum module in Python 3.13+ to handle FutureWarning.

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (503fb68) to head (1346a1a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/backend/cardano_cli.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   88.75%   88.86%   +0.11%     
==========================================
  Files          33       33              
  Lines        4792     4804      +12     
  Branches      730      731       +1     
==========================================
+ Hits         4253     4269      +16     
+ Misses        378      374       -4     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes!

@cffls cffls merged commit b545112 into Python-Cardano:main Jun 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants