-
-
Notifications
You must be signed in to change notification settings - Fork 77
Add TextEnvelope class for saving and loading Witness and Transaction files #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KINGH242
wants to merge
11
commits into
Python-Cardano:main
Choose a base branch
from
KINGH242:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+733
−10
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
313a626
test: add cardano-cli tests for latest
KINGH242 bc363a2
test: add fixtures for transaction failure scenarios in cardano-cli t…
KINGH242 0cf1cd7
feat: add TextEnvelope class for JSON serialization and deserialization
KINGH242 564aed7
test: add tests for network magic and DRep serialization and TextEnve…
KINGH242 82dd140
test: add tests for TextEnvelope and witness
KINGH242 a39bea1
test: add unit tests for BlockFrostChainContext methods to improve co…
KINGH242 72c3b80
lint: clean up imports
KINGH242 2cb8699
fix: remove private properties from repr
KINGH242 b4e6c3a
fix: update vkey handling and improve repr
KINGH242 f30331f
test: add repr call in Transaction test for verification
KINGH242 04f1d48
style: correct typos in function docstrings
KINGH242 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to combine this directly with CBORSerializable, which would instantly enable all pycardano classes to save to and load from json. I don't think private fields,
key_type
anddescription
, are necessary, because they usually don't change between instances. If we want to customize them for certain child class, the child class can always override the methodjson_key_type
orjson_description
. Regardingpayload
, it becomes redundant once the logic is merged to CBORSerializable. The default implementation can directly use the class name as the key type, something like below:Basic usage
Custom key type
