feat: use display name to fix duplicate code mappings - #870
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
allenporter
previously approved these changes
Jul 10, 2026
Collaborator
Author
|
Holding off on this one until closer to the beta, don't want to put us in a weird situation where this breaks anything |
Collaborator
Author
|
stale review due to conflicts. Approve when you can @allenporter want to make sure this gets into beta. |
allenporter
approved these changes
Jul 29, 2026
allenporter
left a comment
allenporter
left a comment
Contributor
There was a problem hiding this comment.
Style issues can be fixed in follow up
| def __new__(cls, value: int, display_name: str | None = None) -> Self: | ||
| member = int.__new__(cls, value) | ||
| member._value_ = value | ||
| member._display_name_ = display_name |
Contributor
There was a problem hiding this comment.
Weird syntax with trailing _
| for item in cls: | ||
| if item.name == "missing": | ||
| continue | ||
| result.setdefault(item.display_name, item.value) |
Contributor
There was a problem hiding this comment.
Can just be regular dict value setting? Don't think set default is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a large portion of our enums that are duplicates. This will be a breaking change on HA, but should likely be okay