Skip to content

fix: show docked Q10 robot on map - #904

Open
tubededentifrice wants to merge 1 commit into
Python-roborock:mainfrom
tubededentifrice:vc/q10-docked-state
Open

fix: show docked Q10 robot on map#904
tubededentifrice wants to merge 1 commit into
Python-roborock:mainfrom
tubededentifrice:vc/q10-docked-state

Conversation

@tubededentifrice

@tubededentifrice tubededentifrice commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

The Q10 map trait now combines map-specific DPS state with map packets so a docked robot remains visible after its live trace disappears.

Changes

  • keep dock status and overlays in one private map DPS snapshot
  • use named dock-state enum values for charging and emptying
  • clear stale and late trace packets when the robot is docked
  • render the docked robot at the saved dock position
  • publish one coherent map update when a DPS payload changes both dock state and overlays
  • keep Q10PropertiesApi independent of map rendering internals

Before / after

These are the real Home Assistant map-card captures from #900.

Before After
Before: Q10 map without the docked robot state After: docked Q10 robot rendered at the saved dock position

Validation

  • pytest -q — 894 passed, 86 snapshots passed
  • pre-commit run --files ... — all hooks passed

Review scope

#902 and #903 are merged. This PR is rebased directly onto main and contains one dock-state composition commit. The transport correction remains independent in #901; #900 is the aggregate before-and-after reference.

Comment thread roborock/devices/traits/b01/q10/map.py Outdated
@tubededentifrice
tubededentifrice marked this pull request as ready for review July 30, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants