Trex mitigation - #181
Conversation
Coverage Report for CI Build 26155713930Coverage decreased (-1.8%) to 91.851%Details
Uncovered ChangesCoverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
95344b2 to
5333696
Compare
caleb-johnson
left a comment
caleb-johnson
left a comment
There was a problem hiding this comment.
A few small comments on the measurement bases module.
caleb-johnson
left a comment
caleb-johnson
left a comment
There was a problem hiding this comment.
This is looking great, just a few comments
| # copyright notice, and modified files need to carry a notice indicating | ||
| # that they have been altered from the originals. | ||
|
|
||
| """ExecutorQuantumProgram.""" |
There was a problem hiding this comment.
Let's put something more descriptive here
| Args: | ||
| shots: The number of shots for each circuit execution. | ||
| items: Items that comprise the program. | ||
| noise_maps: Noise maps to use with samplex items. |
There was a problem hiding this comment.
for noise_maps, can we say what these are and what they're used for if provided?
For passthrough_data, can we give an indication of why this exists and what its function is?
|
|
||
| Args: | ||
| data: A list of dictionaries with array-valued data. | ||
| passthrough_data: Dictionary passed through execution without modification. |
There was a problem hiding this comment.
Same as above. It's not clear what this is from the documentation (as far as I can tell so far)
| # Y commutes with Y, Z commutes with Z | ||
| obs = SparsePauliOp(["YI", "IZ"], [1.0, 2.0]) | ||
| bases = ["YI", "IZ"] | ||
| obs = SparsePauliOp(["YX", "IZ"], [1.0, 2.0]) |
There was a problem hiding this comment.
Have you glanced at the coverage of the new code? Is the TREX source 100% covered?
|
Tick the box to add this pull request to the merge queue (same as
|
4 participants
class for TREX mitigation method. should support the WrapperEstimator flow.